Commit 90df4645 authored by Stefan Tauner's avatar Stefan Tauner
Browse files

Fix some random bugs and refine comments

parent 53ca409a
......@@ -192,7 +192,8 @@ sub sanitize_config {
# \param block_till_ready (optional) Normally the function immediately starts to transmit the new configuration. If this parameter is defined and non-zero the function first waits for a READY message (up to the timeout).
# \param wait_for_ready (optional) Normally the function returns immediately after the CONF_DONE message is received. If this parameter is defined and non-zero the function additionally waits for a READY/UNDERRUN message.
#
# \returns 0 on success
# \returns 1 if no message could be received
# \returns a hash if any message was received (potentially) containing msg_type, fault_detect, error, underrun_occurred
sub send_config {
my $logger = get_logger("");
my ($self, $config_ref, $block_till_ready, $wait_for_ready) = @_;
......
......@@ -33,6 +33,7 @@ use Clone 'clone';
use threads;
use threads::shared;
# FIXME: fix documentation
## @function public new ($testsname,%$existing_tests,$cfgname,%$existing_cfg)
#
# @param testsname (optional) Name of a FIJI::Tests configuration file
......@@ -577,7 +578,8 @@ sub _check_halt ($) {
my $reasons = [];
my $fiji_tests = $self->{'fiji_tests'};
# @FIXME HALT_on_xxx information is defined in tests config file. OK?
# NB: HALT_on_xxx information is defined in tests config file but
# is not setable by any UI. If need be it can be hardcoded in the .ini
if ($recv_msg->{'msg_type'} eq "UNDERRUN") {
$logger->info("UNDERRUN message received. HALT_ON_UNDERRUN = " . $fiji_tests->{'design'}->{'HALT_ON_UNDERRUN'} . ".");
......
......@@ -40,8 +40,6 @@ use FIJI qw(:all);
# @FIXME rather similar to Settings.pm
# Can we generalize this?
# @FIXME which data has to be present in a test configuration file?
## @function public new ($phase, $fiji_ini_file, $existing_settings)
# Create a new settings instance.
#
......
......@@ -46,7 +46,7 @@ sub Populate {
# create the two frames
my $top = $cw->Component('Frame', 'top');
$top->configure(-relief => 'raised', -bd => 1) unless $Tk::platform eq 'MSWin32';
$top->configure(-relief => 'raised', -bd => 1) unless $Tk::platform eq 'MSWin32'; # FIXME: document
my $bot = $cw->Component('Frame', 'bottom');
$bot->configure(-relief => 'raised', -bd => 1) unless $Tk::platform eq 'MSWin32';
$bot->pack(qw/-side bottom -fill both -ipady 3 -ipadx 3/);
......@@ -73,7 +73,7 @@ sub Populate {
);
$b->bind('<Return>' => [ $b, 'Invoke']);
$cw->Advertise("B_$bl" => $b);
if ($Tk::platform eq 'MSWin32')
if ($Tk::platform eq 'MSWin32') # FIXME: document
{
$b->configure(-width => 10, -pady => 0);
}
......
......@@ -66,7 +66,7 @@ if (defined $msg->{'rmsg'} && ref $msg->{'rmsg'} eq "HASH") {
$errors .= "The received message contains errors:\n" if $rmsg->{'error'}->{'ANY'};
$errors .= "\tUART framing error\n" if $rmsg->{'error'}->{'U'};
$errors .= "\tID mismatch\n" if $rmsg->{'error'}->{'I'};
$faultd .= "\tCRC error\n" if $rmsg->{'error'}->{'C'};
$errors .= "\tCRC error\n" if $rmsg->{'error'}->{'C'};
$faultd .= "Fault detect bits set: " if $rmsg->{'fault_detect'}->{'ANY'};
$faultd .= "1 " if $rmsg->{'fault_detect'}->{'1'};
$faultd .= "2 " if $rmsg->{'fault_detect'}->{'2'};
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment