Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
vecs
FIJI Public
Commits
60d47c8c
Commit
60d47c8c
authored
Nov 19, 2015
by
Christian Fibich
Committed by
Stefan Tauner
Oct 03, 2017
Browse files
[Issue #11] Validation warnings are now logged as WARN messages when they ocurr
during validation of GUI elements.
parent
974021c8
Changes
3
Hide whitespace changes
Inline
Side-by-side
bin/FIJI/Settings.pm
View file @
60d47c8c
...
...
@@ -376,7 +376,7 @@ sub validate_fiu_value {
# \param old (optional) previously valid value
# \param log_func (optional) the (log4perl) log function to use
# (defaul is \&Log::Log4perl::Logger::trace)
sub
validate_value
($$$;$$)
{
sub
validate_value
{
my
$logger
=
get_logger
("");
my
(
$map_ref
,
$k
,
$v_ref
,
$dep_ref
,
$old
,
$log_func
)
=
@_
;
$log_func
=
\
&
Log::Log4perl::Logger::
trace
if
!
defined
(
$log_func
);
...
...
bin/Tk/FIJISettingsViewer.pm
View file @
60d47c8c
...
...
@@ -1268,6 +1268,7 @@ sub _validate_fiu_entry {
}
sub
_validate_entry
{
my
$logger
=
get_logger
("");
my
(
$map
,
$self
,
$widget
,
$name
,
$old_ref
,
$new_ref
,
$diff
,
$old_str
,
$char_idx
,
$brokentype
)
=
@_
;
my
$dep_ref
;
...
...
@@ -1276,7 +1277,7 @@ sub _validate_entry {
$dep_ref
=
\
$self
->
{'
settings
'}
->
{'
design
'}
->
{
$map
->
{
$name
}
->
{'
depends_on
'}};
}
my
$ok
=
FIJI::Settings::
validate_value
(
$map
,
$name
,
$new_ref
,
$dep_ref
,
$$old_ref
);
my
$ok
=
FIJI::Settings::
validate_value
(
$map
,
$name
,
$new_ref
,
$dep_ref
,
$$old_ref
,
\
&
Log::Log4perl::Logger::
warn
);
_highlight_widget
(
$widget
,
(
!
$ok
));
# Validate all matching or depending widgets
...
...
bin/Tk/FIJITestsViewer.pm
View file @
60d47c8c
...
...
@@ -859,7 +859,7 @@ sub _validate_design_entry {
sub
_validate_entry
{
my
$logger
=
get_logger
("");
my
(
$map
,
$self
,
$widget
,
$name
,
$old_ref
,
$new_ref
,
$diff
,
$old_str
,
$char_idx
,
$brokentype
)
=
@_
;
my
$stat
=
FIJI::Tests::
validate_value
(
$map
,
$name
,
$new_ref
,
$$old_ref
);
my
$stat
=
FIJI::Tests::
validate_value
(
$map
,
$name
,
$new_ref
,
$$old_ref
,
\
&
Log::Log4perl::Logger::
warn
);
my
$dyn
=
1
;
my
$new
=
$$new_ref
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment